xintongsong commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r395464715
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -351,21 +351,21 @@ public static TaskExecutor startTaskManager(
LOG.info("Starting TaskManager with ResourceID: {}",
resourceID);
- InetAddress remoteAddress =
InetAddress.getByName(rpcService.getAddress());
+ InetAddress externalAddress =
InetAddress.getByName(rpcService.getAddress());
Review comment:
After looking more into this, I'm not entirely sure whether we should
support unresolvable external addresses.
The prerequisites are unclear to me. If an external address cannot be
resolved by the TaskManager itself, then where can it be resolved? Do we assume
all other components (JobManager and other TaskManagers) except for itself can
resolve the external address? That sounds like a strong assumption to me, which
may not always be true. E.g., deploying a Flink cluster over machines from two
different sub-network, each sub-network has multiple machines/TMs. TMs in the
same sub-network might not be able to resolve each other's external address.
Another example, multiple TMs on the same machine.
I don't see a good way to cover all such cases. If we can only support the
special case where external addresses can be resolved by all other components,
I'm not sure whether we should do it given the efforts needed. Alternatively,
user might use IP addresses to workaround in such cases.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
