xintongsong commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r395429730
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -94,19 +94,28 @@
" or if it has been quarantined by another
actor system.");
/**
- * The config parameter defining the task manager's hostname.
+ * The external address of the network interface where the TaskManager
is exposed.
* Overrides {@link #HOST_BIND_POLICY} automatic address binding.
*/
@Documentation.Section({Documentation.Sections.COMMON_HOST_PORT,
Documentation.Sections.ALL_TASK_MANAGER})
public static final ConfigOption<String> HOST =
key("taskmanager.host")
.stringType()
.noDefaultValue()
- .withDescription("The address of the network interface
that the TaskManager binds to." +
- " This option can be used to define explicitly
a binding address. Because" +
- " different TaskManagers need different values
for this option, usually it is specified in an" +
+ .withDescription("The external address of the network
interface where the TaskManager is exposed." +
+ " Because different TaskManagers need different
values for this option, usually it is specified in an" +
" additional non-shared TaskManager-specific
config file.");
+ /**
+ * The local address of the network interface that the task manager
binds to.
+ */
+ public static final ConfigOption<String> BIND_HOST =
+ key("taskmanager.bind-host")
Review comment:
Same here. TM address and bind-address are shared by RPC service, netty
shuffle service and queryable kv state.
I'm actually thinking about changing "jobmanager.rpc.address" to
"jobmanager.host" as a follow up, to make the config keys consistently using
"host".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
