danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade 
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r394772971
 
 

 ##########
 File path: flink-table/flink-sql-parser/src/main/codegen/data/Parser.tdd
 ##########
 @@ -21,69 +21,70 @@
 
   # List of additional classes and packages to import.
   # Example. "org.apache.calcite.sql.*", "java.util.List".
+  # Please keep the import classes in alphabetical order if new class is added.
   imports: [
-    "org.apache.calcite.sql.ExtendedSqlRowTypeNameSpec",
-    "org.apache.calcite.sql.SqlMapTypeNameSpec",
-    "org.apache.flink.sql.parser.ddl.SqlCreateTable",
+    "org.apache.flink.sql.parser.ddl.SqlAlterDatabase"
+    "org.apache.flink.sql.parser.ddl.SqlAlterFunction"
+    "org.apache.flink.sql.parser.ddl.SqlAlterTable"
+    "org.apache.flink.sql.parser.ddl.SqlAlterTableProperties"
+    "org.apache.flink.sql.parser.ddl.SqlAlterTableRename"
+    "org.apache.flink.sql.parser.ddl.SqlCreateCatalog"
+    "org.apache.flink.sql.parser.ddl.SqlCreateDatabase"
+    "org.apache.flink.sql.parser.ddl.SqlCreateFunction"
+    "org.apache.flink.sql.parser.ddl.SqlCreateTable"
+    "org.apache.flink.sql.parser.ddl.SqlCreateTable.TableCreationContext"
+    "org.apache.flink.sql.parser.ddl.SqlCreateView"
+    "org.apache.flink.sql.parser.ddl.SqlDropDatabase"
+    "org.apache.flink.sql.parser.ddl.SqlDropFunction"
     "org.apache.flink.sql.parser.ddl.SqlDropTable"
-    "org.apache.flink.sql.parser.ddl.SqlCreateTable.TableCreationContext",
-    "org.apache.flink.sql.parser.ddl.SqlCreateView",
-    "org.apache.flink.sql.parser.ddl.SqlDropView",
-    "org.apache.flink.sql.parser.ddl.SqlTableColumn",
-    "org.apache.flink.sql.parser.ddl.SqlTableOption",
-    "org.apache.flink.sql.parser.ddl.SqlWatermark",
-    "org.apache.flink.sql.parser.ddl.SqlUseCatalog",
-    "org.apache.flink.sql.parser.ddl.SqlUseDatabase",
-    "org.apache.flink.sql.parser.ddl.SqlCreateDatabase",
-    "org.apache.flink.sql.parser.ddl.SqlDropDatabase",
-    "org.apache.flink.sql.parser.ddl.SqlAlterDatabase",
-    "org.apache.flink.sql.parser.ddl.SqlAlterFunction",
-    "org.apache.flink.sql.parser.ddl.SqlCreateFunction",
-    "org.apache.flink.sql.parser.ddl.SqlDropFunction",
-    "org.apache.flink.sql.parser.ddl.SqlAlterTable",
-    "org.apache.flink.sql.parser.ddl.SqlAlterTableRename",
-    "org.apache.flink.sql.parser.ddl.SqlAlterTableProperties",
-    "org.apache.flink.sql.parser.ddl.SqlCreateCatalog",
-    "org.apache.flink.sql.parser.dml.RichSqlInsert",
-    "org.apache.flink.sql.parser.dml.RichSqlInsertKeyword",
-    "org.apache.flink.sql.parser.dql.SqlShowCatalogs",
-    "org.apache.flink.sql.parser.dql.SqlDescribeCatalog",
-    "org.apache.flink.sql.parser.dql.SqlShowDatabases",
-    "org.apache.flink.sql.parser.dql.SqlShowFunctions",
-    "org.apache.flink.sql.parser.dql.SqlDescribeDatabase",
-    "org.apache.flink.sql.parser.dql.SqlShowTables",
-    "org.apache.flink.sql.parser.dql.SqlRichDescribeTable",
-    "org.apache.flink.sql.parser.type.ExtendedSqlBasicTypeNameSpec",
-    "org.apache.flink.sql.parser.type.ExtendedSqlCollectionTypeNameSpec",
-    "org.apache.flink.sql.parser.utils.SqlTimeUnit",
-    "org.apache.flink.sql.parser.utils.ParserResource",
-    "org.apache.flink.sql.parser.validate.FlinkSqlConformance",
-    "org.apache.flink.sql.parser.SqlProperty",
-    "org.apache.calcite.sql.SqlDrop",
-    "org.apache.calcite.sql.SqlCreate",
-    "java.util.List",
+    "org.apache.flink.sql.parser.ddl.SqlDropView"
+    "org.apache.flink.sql.parser.ddl.SqlTableColumn"
+    "org.apache.flink.sql.parser.ddl.SqlTableOption"
+    "org.apache.flink.sql.parser.ddl.SqlUseCatalog"
+    "org.apache.flink.sql.parser.ddl.SqlUseDatabase"
+    "org.apache.flink.sql.parser.ddl.SqlWatermark"
+    "org.apache.flink.sql.parser.dml.RichSqlInsert"
+    "org.apache.flink.sql.parser.dml.RichSqlInsertKeyword"
+    "org.apache.flink.sql.parser.dql.SqlDescribeCatalog"
+    "org.apache.flink.sql.parser.dql.SqlDescribeDatabase"
+    "org.apache.flink.sql.parser.dql.SqlShowCatalogs"
+    "org.apache.flink.sql.parser.dql.SqlShowDatabases"
+    "org.apache.flink.sql.parser.dql.SqlShowFunctions"
+    "org.apache.flink.sql.parser.dql.SqlShowTables"
+    "org.apache.flink.sql.parser.dql.SqlRichDescribeTable"
+    "org.apache.flink.sql.parser.type.ExtendedSqlCollectionTypeNameSpec"
+    "org.apache.flink.sql.parser.type.ExtendedSqlRowTypeNameSpec"
+    "org.apache.flink.sql.parser.type.SqlMapTypeNameSpec"
+    "org.apache.flink.sql.parser.utils.SqlTimeUnit"
+    "org.apache.flink.sql.parser.utils.ParserResource"
+    "org.apache.flink.sql.parser.validate.FlinkSqlConformance"
+    "org.apache.flink.sql.parser.SqlProperty"
+    "org.apache.calcite.sql.SqlAlienSystemTypeNameSpec"
+    "org.apache.calcite.sql.SqlCreate"
+    "org.apache.calcite.sql.SqlDrop"
+    "java.util.List"
     "java.util.ArrayList"
   ]
 
   # List of new keywords. Example: "DATABASES", "TABLES". If the keyword is 
not a reserved
   # keyword, please also add it to 'nonReservedKeywords' section.
 
 Review comment:
   Agree, thanks ~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to