danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#discussion_r396865349
########## File path: flink-table/flink-table-planner-blink/pom.xml ########## @@ -149,20 +135,28 @@ under the License. <version>${calcite.version}</version> <exclusions> <!-- - "mvn dependency:tree" as of Calcite 1.21: + "mvn dependency:tree" as of Calcite 1.22.0: - [INFO] +- org.apache.calcite:calcite-core:jar:1.21.0:compile - [INFO] | +- commons-codec:commons-codec:jar:1.10:compile - [INFO] | +- org.apache.calcite:calcite-linq4j:jar:1.21.0:compile - [INFO] | +- org.apache.commons:commons-lang3:jar:3.3.2:compile - [INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.10.1:compile + [INFO] +- org.apache.calcite:calcite-core:jar:1.22.0:compile + [INFO] | +- org.apache.calcite:calcite-linq4j:jar:1.22.0:compile [INFO] | +- com.fasterxml.jackson.core:jackson-annotations:jar:2.10.1:compile - [INFO] | +- com.fasterxml.jackson.core:jackson-databind:jar:2.10.1:compile - [INFO] | +- com.google.guava:guava:jar:19.0:compile - [INFO] | \- com.jayway.jsonpath:json-path:jar:2.4.0:compile + [INFO] | +- org.apiguardian:apiguardian-api:jar:1.1.0:compile + [INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.10.1:runtime + [INFO] | +- com.fasterxml.jackson.core:jackson-databind:jar:2.10.1:runtime + [INFO] | +- com.jayway.jsonpath:json-path:jar:2.4.0:runtime + [INFO] | | \- net.minidev:json-smart:jar:2.3:runtime Review comment: commons-lang3 is a conflict prone jar, we should shade it. So user that depends on flink would not have conflict. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services