danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade 
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r397574390
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/pom.xml
 ##########
 @@ -149,20 +135,28 @@ under the License.
                        <version>${calcite.version}</version>
                        <exclusions>
                                <!--
-                               "mvn dependency:tree" as of Calcite 1.21:
+                               "mvn dependency:tree" as of Calcite 1.22.0:
 
-                               [INFO] +- 
org.apache.calcite:calcite-core:jar:1.21.0:compile
-                               [INFO] |  +- 
commons-codec:commons-codec:jar:1.10:compile
-                               [INFO] |  +- 
org.apache.calcite:calcite-linq4j:jar:1.21.0:compile
-                               [INFO] |  +- 
org.apache.commons:commons-lang3:jar:3.3.2:compile
-                               [INFO] |  +- 
com.fasterxml.jackson.core:jackson-core:jar:2.10.1:compile
+                               [INFO] +- 
org.apache.calcite:calcite-core:jar:1.22.0:compile
+                               [INFO] |  +- 
org.apache.calcite:calcite-linq4j:jar:1.22.0:compile
                                [INFO] |  +- 
com.fasterxml.jackson.core:jackson-annotations:jar:2.10.1:compile
-                               [INFO] |  +- 
com.fasterxml.jackson.core:jackson-databind:jar:2.10.1:compile
-                               [INFO] |  +- 
com.google.guava:guava:jar:19.0:compile
-                               [INFO] |  \- 
com.jayway.jsonpath:json-path:jar:2.4.0:compile
+                               [INFO] |  +- 
org.apiguardian:apiguardian-api:jar:1.1.0:compile
+                               [INFO] |  +- 
com.fasterxml.jackson.core:jackson-core:jar:2.10.1:runtime
+                               [INFO] |  +- 
com.fasterxml.jackson.core:jackson-databind:jar:2.10.1:runtime
+                               [INFO] |  +- 
com.jayway.jsonpath:json-path:jar:2.4.0:runtime
+                               [INFO] |  |  \- 
net.minidev:json-smart:jar:2.3:runtime
 
 Review comment:
   I have removed the relocation of `commons-lang3` because all the other 
modules in Flink does not do that, although it is indeed a conflict prone jar, 
we can do that uniformly if we think it is necessary in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to