zhengcanbin commented on issue #11233: [FLINK-16194][k8s] Refactor the Kubernetes decorator design URL: https://github.com/apache/flink/pull/11233#issuecomment-593316748 > @zhengcanbin Thanks a lot for addressing the comments. I have gone though again and the changes look really good to me. I just leave few minor comments. > > For the real K8s cluster tests. > > * Non-HA session cluster > > * deploy [SUCCEED] > * submit Flink job via `CLI` [SUCCEED] > * submit Flink job via webui [SUCCEED] > * cancel all jobs and taskmanager released by idle [SUCCEED] > * stop via `kubernetes-session.sh` [FAILED] > * stop via `kubectl delete deployment/<Cluster_ID>` [SUCCEED] > > * HA session cluster > > * Same operations as above [SUCCEED] > * Kill taskmanager, job failover and resume successfully [SUCCEED] > * Kill jobmanager, job failover and resume successfully [SUCCEED] @wangyang0918 Thanks for the testing work and all the comments. I have resolved the new comments via commit [b088e0e](https://github.com/apache/flink/pull/11233/commits/b088e0e0530fa3178a547b26b7e950165181caaf).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
