zhengcanbin commented on a change in pull request #11233: [FLINK-16194][k8s]
Refactor the Kubernetes decorator design
URL: https://github.com/apache/flink/pull/11233#discussion_r386286390
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -66,8 +70,52 @@ public Fabric8FlinkKubeClient(Configuration flinkConfig,
KubernetesClient client
}
@Override
- public void createTaskManagerPod(TaskManagerPodParameter parameter) {
- // todo
+ public void createJobManagerComponent(KubernetesJobManagerSpecification
kubernetesJMSpec) {
+ final Deployment deployment = kubernetesJMSpec.getDeployment();
+ final List<HasMetadata> accompanyingResources =
kubernetesJMSpec.getAccompanyingResources();
+
+ // create Deployment
+ LOG.debug("Start to create deployment with spec {}",
deployment.getSpec().toString());
+ final Deployment createdDeployment = this.internalClient
+ .apps()
+ .deployments()
+ .inNamespace(this.nameSpace)
+ .create(deployment);
+
+ // Note, we should use the server-side uid of the created
Deployment for the OwnerReference.
+ setOwnerReference(createdDeployment, accompanyingResources);
Review comment:
Good catch. Fixed by
[b088e0e](https://github.com/apache/flink/pull/11233/commits/b088e0e0530fa3178a547b26b7e950165181caaf)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
