wangyang0918 commented on a change in pull request #11233: [FLINK-16194][k8s] Refactor the Kubernetes decorator design URL: https://github.com/apache/flink/pull/11233#discussion_r386202186
########## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/JavaCmdTaskManagerDecorator.java ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.kubeclient.decorators; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.kubernetes.kubeclient.FlinkPod; +import org.apache.flink.kubernetes.kubeclient.parameters.KubernetesTaskManagerParameters; +import org.apache.flink.kubernetes.taskmanager.KubernetesTaskExecutorRunner; +import org.apache.flink.kubernetes.utils.KubernetesUtils; +import org.apache.flink.runtime.clusterframework.ContaineredTaskManagerParameters; +import org.apache.flink.runtime.clusterframework.TaskExecutorProcessSpec; +import org.apache.flink.runtime.clusterframework.TaskExecutorProcessUtils; +import org.apache.flink.runtime.entrypoint.parser.CommandLineOptions; + +import io.fabric8.kubernetes.api.model.Container; +import io.fabric8.kubernetes.api.model.ContainerBuilder; + +import javax.annotation.Nullable; + +import java.util.Arrays; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * Attach the command and args to the main container for running the TaskManager code. + */ +public class JavaCmdTaskManagerDecorator extends AbstractKubernetesStepDecorator { + + private final KubernetesTaskManagerParameters kubernetesTaskManagerParameters; + + public JavaCmdTaskManagerDecorator(KubernetesTaskManagerParameters kubernetesTaskManagerParameters) { + this.kubernetesTaskManagerParameters = checkNotNull(kubernetesTaskManagerParameters); + } + + @Override + public FlinkPod decorateFlinkPod(FlinkPod flinkPod) { + final Container mainContainerWithStartCmd = new ContainerBuilder(flinkPod.getMainContainer()) + .withCommand(kubernetesTaskManagerParameters.getContainerEntrypoint()) + .withArgs(Arrays.asList("/bin/bash", "-c", getTaskManagerStartCommand())) + .build(); + + return new FlinkPod.Builder(flinkPod) + .withMainContainer(mainContainerWithStartCmd) + .build(); + } + + private String getTaskManagerStartCommand() { + final String confDirInPod = kubernetesTaskManagerParameters.getFlinkConfDirInPod(); + + final String logDirInPod = kubernetesTaskManagerParameters.getFlinkLogDirInPod(); + + final String mainClassArgs = "--" + CommandLineOptions.CONFIG_DIR_OPTION.getLongOpt() + " " + + confDirInPod + " " + kubernetesTaskManagerParameters.getDynamicProperties(); + + return getTaskManagerStartCommand( + kubernetesTaskManagerParameters.getFlinkConfiguration(), + kubernetesTaskManagerParameters.getContaineredTaskManagerParameters(), + confDirInPod, + logDirInPod, + kubernetesTaskManagerParameters.hasLogback(), + kubernetesTaskManagerParameters.hasLog4j(), + KubernetesTaskExecutorRunner.class.getCanonicalName(), + mainClassArgs); + } + + private static String getTaskManagerStartCommand( + Configuration flinkConfig, + ContaineredTaskManagerParameters tmParams, + String configDirectory, + String logDirectory, + boolean hasLogback, + boolean hasLog4j, + String mainClass, + @Nullable String mainArgs) { Review comment: `@Nullable` could be removed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
