docete commented on a change in pull request #10904: [FLINK-15669] [sql client] 
fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#discussion_r375690809
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
 ##########
 @@ -1270,4 +1362,22 @@ private void executeAndVerifySinkResult(
                }
                return actualResults;
        }
+
+       private JobStatus getJobStatus(LocalExecutor executor, String 
sessionId, JobID jobId) {
+               final ExecutionContext<?> context = 
executor.getExecutionContext(sessionId);
+               return getJobStatusInternal(context, jobId);
+       }
+
+       private <T> JobStatus getJobStatusInternal(ExecutionContext<T> context, 
JobID jobId) {
+               // stop Flink job
 
 Review comment:
   useless comments?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to