docete commented on a change in pull request #10904: [FLINK-15669] [sql client]
fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#discussion_r375688351
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectBatchResult.java
##########
@@ -76,10 +77,9 @@ public boolean isMaterialized() {
}
@Override
- public void startRetrieval(ProgramDeployer deployer) {
- deployer
- .deploy()
- .thenCompose(jobClient ->
jobClient.getJobExecutionResult(classLoader))
+ public void startRetrieval(JobClient jobClient) {
+ CompletableFuture.completedFuture(jobClient)
+ .thenCompose(client ->
client.getJobExecutionResult(classLoader))
Review comment:
Should change the exception message since we only retrieve results here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
