docete commented on a change in pull request #10904: [FLINK-15669] [sql client]
fix SQL client can't cancel flink job
URL: https://github.com/apache/flink/pull/10904#discussion_r375687425
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -657,11 +654,23 @@ public ProgramTargetDescriptor executeUpdate(String
sessionId, String statement)
final ProgramDeployer deployer = new ProgramDeployer(
configuration, jobName, pipeline);
+ JobClient jobClient;
+ // blocking deployment
+ try {
+ jobClient = deployer.deploy().get();
+ } catch (Exception e) {
+ throw new SqlExecutionException("Error running SQL
job.", e);
Review comment:
`Error while submitting SQL job` is more accurate for the exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
