wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn]
Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r346672001
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -509,7 +536,8 @@ static ContainerLaunchContext createTaskExecutorContext(
appId,
new Path(taskManagerConfigFile.toURI()),
homeDirPath,
- "").f1;
+ "",
+ null).f1;
Review comment:
I think `null` means we always do not need to use pre-uploaded file for this
local file. If you prefer add a new function and check not null outside of
`setupSingleLocalResource`, i will do as you say.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
