zhijiangW commented on a change in pull request #9854: [FLINK-14230][task] 
Change the endInput call of the downstream operator to after the upstream 
operator closes
URL: https://github.com/apache/flink/pull/9854#discussion_r338499527
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -577,6 +577,13 @@ private void closeAllOperators() throws Exception {
                        if (operator != null) {
                                operator.close();
                        }
+
+                       // The operators on the chain, except for the head 
operator, must be one-input operators.
+                       // So after the upstream operator on the chain is 
closed, the input of its downstream operator
+                       // reaches the end.
+                       if (i > 0) {
+                               operatorChain.endOperatorInput(i - 1, 1);
 
 Review comment:
   use `operatorChain.endNonHeadOperatorInput(operator)` instead

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to