zhijiangW commented on a change in pull request #9854: [FLINK-14230][task]
Change the endInput call of the downstream operator to after the upstream
operator closes
URL: https://github.com/apache/flink/pull/9854#discussion_r338863841
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
##########
@@ -1023,44 +999,6 @@ public void asyncInvoke(IN input, ResultFuture<OUT>
resultFuture) throws Excepti
return in.transform("async wait operator", outTypeInfo,
factory);
}
- /**
- * Delay a while before async invocation to check whether end input
waits for all elements finished or not.
- */
- @Test
- public void testEndInput() throws Exception {
Review comment:
I am not sure whether we already have the tests to cover the case that
`AsyncWaitOperator#close()` would wait for the inflight input finish. If not
covered yet, we might refactor this test a bit for verifying that, because it
is exactly the case that this PR wants to fix in practice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
