zhijiangW commented on a change in pull request #9854: [FLINK-14230][task]
Change the endInput call of the downstream operator to after the upstream
operator closes
URL: https://github.com/apache/flink/pull/9854#discussion_r338499406
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
##########
@@ -106,8 +106,10 @@ public void run(final Object lockingObject,
if (!isCanceledOrStopped()) {
advanceToEndOfEventTime();
+ // in theory, the subclasses of StreamSource
may implement the BoundedOneInput interface,
+ // so we still need the following call to end
the input
synchronized (lockingObject) {
- operatorChain.endInput(1);
+ operatorChain.endOperatorInput(this, 1);
Review comment:
`streamOperator` as head operator could be got directly from
`operatorChain`, so we could provide `operatorChain#endHeadOperatorInput(int
inputIndex)` to avoid passing `streamOperator` in the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
