TisonKun commented on a change in pull request #9832: [FLINK-11843] Bind
lifespan of Dispatcher to leader session
URL: https://github.com/apache/flink/pull/9832#discussion_r336502919
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -197,19 +191,37 @@ public void onStart() throws Exception {
onFatalError(exception);
throw exception;
}
+
+ startRecoveredJobs();
Review comment:
`onAddedJobGraph` submits the job graph from DispatcherProcess. Could we
follow that pattern in DispatcherProcess start Dispatcher and follow by submit
recovered job graphs? It would exclude "recovered" concern from `Dispatcher`
and keep the recovery things out side of it.
> BTW `onAddedJobGraph` as well as `JobGraphStoreListener` is another ZK
specific add-on high-availability concept.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
