TisonKun commented on a change in pull request #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session URL: https://github.com/apache/flink/pull/9832#discussion_r336499679
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherFactory.java ########## @@ -34,7 +36,9 @@ */ Dispatcher createDispatcher( @Nonnull RpcService rpcService, Review comment: No `@Nonnull` I think. We don't mark `@Nonnull` in `SessionDispatcherFactory` though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services