TisonKun commented on a change in pull request #9832: [FLINK-11843] Bind 
lifespan of Dispatcher to leader session
URL: https://github.com/apache/flink/pull/9832#discussion_r337825706
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherServices.java
 ##########
 @@ -74,22 +78,24 @@ public DispatcherServices(
                        @Nonnull GatewayRetriever<ResourceManagerGateway> 
resourceManagerGatewayRetriever,
 
 Review comment:
   I'm afraid `org.apache.flink.runtime.dispatcher.DispatcherServices` has a 
name conflict with 
`org.apache.flink.runtime.dispatcher.runner.AbstractDispatcherLeaderProcess.DispatcherService`.
 Technically we can distinguish by package/namespace but it possibly brings 
confusion later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to