lirui-apache commented on a change in pull request #8890: [FLINK-12989][hive]:
Generate HiveTableSink from from a Hive table
URL: https://github.com/apache/flink/pull/8890#discussion_r298025960
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableSink.java
##########
@@ -55,30 +58,31 @@
public class HiveTableSink extends OutputFormatTableSink<Row> {
private final JobConf jobConf;
+ private final CatalogTableImpl catalogTable;
+ private final ObjectPath tablePath;
private final RowTypeInfo rowTypeInfo;
- private final String dbName;
- private final String tableName;
- private final List<String> partitionColumns;
private final String hiveVersion;
// TODO: need OverwritableTableSink to configure this
private boolean overwrite = false;
- public HiveTableSink(JobConf jobConf, RowTypeInfo rowTypeInfo, String
dbName, String tableName,
- List<String> partitionColumns) {
+ public HiveTableSink(JobConf jobConf, ObjectPath tablePath,
CatalogTableImpl table) {
Review comment:
Seems we just need a CatalogTable here too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
