lirui-apache commented on a change in pull request #8890: [FLINK-12989][hive]:
Generate HiveTableSink from from a Hive table
URL: https://github.com/apache/flink/pull/8890#discussion_r297499365
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogTableImpl.java
##########
@@ -32,65 +32,39 @@
import static org.apache.flink.util.Preconditions.checkNotNull;
/**
- * An abstract catalog table.
+ * A catalog table implementation.
*/
-public class CatalogTableImpl implements CatalogTable {
- // Schema of the table (column names and types)
- private final TableSchema tableSchema;
- // Partition keys if this is a partitioned table. It's an empty set if
the table is not partitioned
- private final List<String> partitionKeys;
- // Properties of the table
- private final Map<String, String> properties;
- // Comment of the table
- private final String comment;
+public class CatalogTableImpl extends AbstractCatalogTable {
+
+ // The path of the table in its catalog.
+ private final ObjectPath tablePath;
public CatalogTableImpl(
- TableSchema tableSchema,
- Map<String, String> properties,
- String comment) {
- this(tableSchema, new ArrayList<>(), properties, comment);
+ ObjectPath tablePath,
+ TableSchema tableSchema,
+ Map<String, String> properties,
+ String comment) {
+ this(tablePath, tableSchema, new ArrayList<>(), properties,
comment);
}
public CatalogTableImpl(
+ ObjectPath tablePath,
Review comment:
If a CatalogTable can have an ObjectPath field, do we need some validation
in APIs like `HiveCatalog::createTable`?
And btw, why did we decide to separate CatalogTable and ObjectPath in the
first place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
