lirui-apache commented on a change in pull request #8890: [FLINK-12989][hive]:
Generate HiveTableSink from from a Hive table
URL: https://github.com/apache/flink/pull/8890#discussion_r297497943
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectPath.java
##########
@@ -28,8 +31,19 @@
* A database name and object (table/view/function) name combo in a catalog.
*/
public class ObjectPath {
- private final String databaseName;
- private final String objectName;
+ // Default database name
Review comment:
How about just make ObjectPath a Serializable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
