zhijiangW commented on a change in pull request #8320:
[FLINK-12201][network,metrics] Introduce InputGateWithMetrics in Task to
increment numBytesIn metric
URL: https://github.com/apache/flink/pull/8320#discussion_r289289629
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferOrEvent.java
##########
@@ -43,26 +44,32 @@
private int channelIndex;
- BufferOrEvent(Buffer buffer, int channelIndex, boolean moreAvailable) {
+ private final int size;
+
+ public BufferOrEvent(Buffer buffer, int channelIndex, boolean
moreAvailable, int size) {
Review comment:
For event buffer, we might not return 0, so we have the explicit size field,
but we do not need pass the size for buffer constructor as you suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
