zhijiangW commented on a change in pull request #8320:
[FLINK-12201][network,metrics] Introduce InputGateWithMetrics in Task to
increment numBytesIn metric
URL: https://github.com/apache/flink/pull/8320#discussion_r289016052
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
##########
@@ -227,39 +229,22 @@ protected ResultPartitionWriter createResultPartition(
}
private InputGate createInputGate(
- IntermediateDataSetID dataSetID,
- ExecutionAttemptID executionAttemptID,
final TaskManagerLocation senderLocation,
- NetworkEnvironment environment,
+ final SingleInputGateFactory gateFactory,
Review comment:
I also found this issue before, but considering all the fields in this class
are defined as protected, so I keep the way as others.
Also for the class field factory, I keep the way as field `channels` to
pass because it is not initialized in the constructor. Actually I also think
many other fields in this class could not be passed as well.
Do you think we should further refactoring this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
