zhijiangW commented on a change in pull request #8320: [FLINK-12201][network,metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric URL: https://github.com/apache/flink/pull/8320#discussion_r289288850
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/InputGateWithMetrics.java ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.taskmanager; + +import org.apache.flink.metrics.Counter; +import org.apache.flink.runtime.event.TaskEvent; +import org.apache.flink.runtime.io.network.partition.consumer.BufferOrEvent; +import org.apache.flink.runtime.io.network.partition.consumer.InputGate; +import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup; + +import java.io.IOException; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * This class wraps {@link InputGate} provided by shuffle service and it is mainly + * used for increasing general input metrics from {@link TaskIOMetricGroup}. + */ +public class InputGateWithMetrics extends InputGate { + + private final InputGate inputGate; + + private final Counter numBytesIn; + + public InputGateWithMetrics(InputGate inputGate, Counter numBytesIn) { + this.inputGate = checkNotNull(inputGate); + this.numBytesIn = checkNotNull(numBytesIn); + } + + @Override + public CompletableFuture<?> isAvailable() { + return inputGate.isAvailable(); + } + + @Override + public int getNumberOfInputChannels() { + return inputGate.getNumberOfInputChannels(); + } + + @Override + public String getOwningTaskName() { + return inputGate.getOwningTaskName(); + } + + @Override + public boolean isFinished() { + return inputGate.isFinished(); + } + + @Override + public void setup() throws IOException { + inputGate.setup(); + } + + @Override + public void requestPartitions() throws IOException, InterruptedException { + inputGate.requestPartitions(); + } + + @Override + public Optional<BufferOrEvent> getNextBufferOrEvent() throws IOException, InterruptedException { + Optional<BufferOrEvent> bufferOrEvent = inputGate.getNextBufferOrEvent(); Review comment: We could deduplicate one common line here, but I am not clear why decrease changes out of sync. Are there any syncs related to here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
