sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add
connection and socket timeouts for the blob client
URL: https://github.com/apache/flink/pull/8484#discussion_r287633012
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/BlobServerOptions.java
##########
@@ -102,4 +102,20 @@
public static final ConfigOption<Integer> OFFLOAD_MINSIZE =
key("blob.offload.minsize")
.defaultValue(1_024 * 1_024) // 1MiB by default
.withDescription("The minimum size for messages to be offloaded
to the BlobServer.");
+
+ /**
+ * The socket timeout in milliseconds for the blob client.
+ */
+ public static final ConfigOption<Integer> SO_TIMEOUT =
+ key("blob.client.socket.timeout")
+ .defaultValue(120_000)
Review comment:
` 2 minutes` is a value that I give freely, and it has little basis, just
considering that a slightly longer wait may be required in the case of high CPU
load. In fact, the blob client has a retry mechanism, and we should set it a
smaller. Do you have any recommended values about connection and socket
timeouts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
