sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add
connection and socket timeouts for the blob client
URL: https://github.com/apache/flink/pull/8484#discussion_r288033314
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/BlobServerOptions.java
##########
@@ -102,4 +102,20 @@
public static final ConfigOption<Integer> OFFLOAD_MINSIZE =
key("blob.offload.minsize")
.defaultValue(1_024 * 1_024) // 1MiB by default
.withDescription("The minimum size for messages to be offloaded
to the BlobServer.");
+
+ /**
+ * The socket timeout in milliseconds for the blob client.
+ */
+ public static final ConfigOption<Integer> SO_TIMEOUT =
+ key("blob.client.socket.timeout")
+ .defaultValue(120_000)
Review comment:
You're right. I didn't think of that. Or the default connection timeout is
set to `0`, while SO_TIMEOUT is still set to `2 minutes` ? @tillrohrmann
`SO_TIMEOUT` takes effect only after the connection is successful, so there
are no problems due to the limit of 50 concurrent connections. Setting the
connection timeout to `0` will not break existing setups, and setting the
socket timeout to the value greater than 0 can fix the deadlock reported by
this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
