sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add
connection and socket timeouts for the blob client
URL: https://github.com/apache/flink/pull/8484#discussion_r287637335
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
##########
@@ -58,7 +58,7 @@ public static void startSSLServer() throws IOException {
Configuration config =
SSLUtilsTest.createInternalSslConfigWithKeyAndTrustStores();
config.setString(BlobServerOptions.STORAGE_DIRECTORY,
temporarySslFolder.newFolder().getAbsolutePath());
- blobSslServer = new BlobServer(config, new VoidBlobStore());
+ blobSslServer = new TestBlobServer(config, new VoidBlobStore());
Review comment:
`BlobClientSslTest` inherits `BlobClientTest`, and it will also execute the
new test `testSocketTimeout` added in `BlobClientTest`. If `TestBlobServer` is
not used here, an error will occur.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
