zhijiangW commented on issue #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#issuecomment-493419719 Thanks for the updates @azagrebin ! It seems much better now. I have other two concerns: - It is really nice now to introduce some builders for constructing `ResultPartition`, `SingleInputGate` and `InputChannel`. But there still exits various utils in tests to support various of parameter units for creating these items. It might bring unnecessary changes every time when make changes for partition/gate/channel. Even these scattered utils make hard to maintain and still could not provide everything. So I want to remove all these unnecessary utils in tests to unified use the proposed builder, maybe not in the scope of this PR. - I was ever a bit confused of the proposed `MemorySegmentProvider` interface, because I think the new introduced methods should be extended in existing `BufferProvider` and `BufferRecycler` to support the batch of buffer requesting/recycle. But now I think it seems make sense to do as now, because it is very simple to let `NetworkBufferPool` implement the new interface and `NetworkBufferPool` actually has the corresponding functions internally before.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
