twalthr commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r284110334
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/aggfunctions/RankLikeAggFunctionBase.java
##########
@@ -98,30 +108,30 @@ protected Expression orderKeyEqualsExpression() {
return ret.orElseGet(() -> literal(true));
}
- protected Expression generateInitLiteral(InternalType orderType) {
- if (orderType.equals(InternalTypes.BOOLEAN)) {
+ protected Expression generateInitLiteral(LogicalType orderType) {
+ if (orderType instanceof BooleanType) {
Review comment:
I would recommend to use the provided visitors instead. I also have a
default visitor in my FLINK-12254 branch. FLINK-12254 will add a lot of tooling
around types as well. Maybe this PR was a bit too early, but this is no problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
