JingsongLi commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r283688763
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala
##########
@@ -602,7 +602,7 @@ class RexTimeIndicatorMaterializerUtils(rexBuilder:
RexBuilder) {
private def timestamp(isNullable: Boolean): RelDataType = rexBuilder
.getTypeFactory
.asInstanceOf[FlinkTypeFactory]
- .createTypeFromInternalType(InternalTypes.TIMESTAMP, isNullable =
isNullable)
+ .createTypeFromLogicalType(new TimestampType(), isNullable = isNullable)
Review comment:
I think this PR is big enough. My idea is to override the functionality of
`InternalType` first, and then to extend the functionality(like nullable) of
`LogicalType` in the next PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
