JingsongLi commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r283684788
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/TimestampType.java
##########
@@ -152,12 +152,14 @@ public boolean equals(Object o) {
if (!super.equals(o)) {
return false;
}
+
TimestampType that = (TimestampType) o;
- return precision == that.precision;
+
+ return precision == that.precision && kind == that.kind;
Review comment:
Yes, `TimeIndicatorTypeInfo` and `SqlTimeTypeInfo.TIMESTAMP` also have same
behavior.
But why are the kind does not affect equality and hashCode?
Is it for `Timestamp(6) of ROWTIME` and `Timestamp(6) of REGULAR` to
interoperate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
