JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283661498
########## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/types/logical/LogicalTypeUtils.java ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.logical; + +/** + * Utilities for {@link LogicalType}. + */ +public class LogicalTypeUtils { + + /** + * Gets the arity of the type. + */ + public static int getArity(LogicalType t) { + if (t instanceof RowType) { + return ((RowType) t).getFieldCount(); + } else { + return 1; + } + } + + public static Class getExternalClassForType(LogicalType type) { + return LogicalTypeConverters.createExternalTypeInfoFromLogicalType(type).getTypeClass(); + } + + public static Class getInternalClassForType(LogicalType type) { + return LogicalTypeConverters.createInternalTypeInfoFromLogicalType(type).getTypeClass(); + } + + public static RowType toRowType(LogicalType t) { + if (t instanceof RowType) { + return (RowType) t; + } else { + return RowType.of(t); + } + } + + public static boolean isPrimitive(LogicalType type) { + return type instanceof BooleanType || type instanceof TinyIntType || type instanceof SmallIntType || + type instanceof IntType || type instanceof BigIntType || type instanceof FloatType || + type instanceof DoubleType; + } + + public static boolean isAtomic(LogicalType type) { + return isPrimitive(type) || type instanceof DecimalType || type instanceof VarCharType || + type instanceof TimeType || type instanceof TimestampType || type instanceof DateType || + type instanceof BinaryType || type instanceof YearMonthIntervalType || type instanceof DayTimeIntervalType; Review comment: I'll remove this useless method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
