tillrohrmann commented on a change in pull request #6898: [FLINK-10431]
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r227871624
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
##########
@@ -136,12 +143,13 @@
private String jobManagerAddress;
+ private MainThreadExecutable jmMainThreadScheduledExecutor;
+
//
------------------------------------------------------------------------
@VisibleForTesting
- protected SlotPool(RpcService rpcService, JobID jobId,
SchedulingStrategy schedulingStrategy) {
+ protected SlotPool(JobID jobId, SchedulingStrategy schedulingStrategy) {
Review comment:
This class still contains a lot of code which actually moved to the new
`Scheduler`. Can we remove this code? Having this code still in this class
makes it extremely hard to review. Of course, this would mean that we also need
to adapt the `SlotPoolTests` which makes sense anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
