Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6323#discussion_r202506661
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
 ---
    @@ -143,118 +143,82 @@ case class CatalogAlreadyExistException(
     }
     
     /**
    -  * Exception for not finding a [[TableFormatFactory]] for the
    -  * given properties.
    +  * Exception for not finding a [[TableFactory]] for the given properties.
       *
       * @param message message that indicates the current matching step
       * @param factoryClass required factory class
    -  * @param formatFactories all found factories
    -  * @param properties properties that describe the table format
    +  * @param factories all found factories
    +  * @param properties properties that describe the configuration
       * @param cause the cause
       */
    -case class NoMatchingTableFormatException(
    +case class NoMatchingTableFactoryException(
           message: String,
           factoryClass: Class[_],
    -      formatFactories: Seq[TableFormatFactory[_]],
    +      factories: Seq[TableFactory],
           properties: Map[String, String],
           cause: Throwable)
         extends RuntimeException(
    --- End diff --
    
    So far we don't have an inheritance of exceptions. Case classes don't 
support that in Scala so we would need to convert them. 


---

Reply via email to