[GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6323#discussion_r202506494
  
    --- Diff: 
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SourceSink.java
 ---
    @@ -51,16 +51,10 @@ public void addProperties(DescriptorProperties 
properties) {
        }
     
        public Source toSource() {
    -           final Map<String, String> newProperties = new 
HashMap<>(properties);
    -           newProperties.replace(TableDescriptorValidator.TABLE_TYPE(),
    -                           
TableDescriptorValidator.TABLE_TYPE_VALUE_SOURCE());
    --- End diff --
    
    The table type is a concept of the SQL Client and should not be part of the 
table descriptor.


---