Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6323#discussion_r202506193
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactory.scala
 ---
    @@ -16,14 +16,14 @@
      * limitations under the License.
      */
     
    -package org.apache.flink.table.connectors
    +package org.apache.flink.table.factories
     
     import java.util
     
     /**
       * Common trait for all properties-based discoverable table factories.
       */
    -trait DiscoverableTableFactory {
    +trait TableFactory {
    --- End diff --
    
    Actually, I would like the very generic name `Factory` but since we have to 
add some prefix to make it unique in the project, I named it `TableFactory` 
because we prefix everything in this module with `Table`.


---

Reply via email to