Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202059575
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
createClusterSpecification(Configuration configurat
}
// JobManager Memory
- final int jobManagerMemoryMB =
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
+ final int jobManagerMemoryMB =
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY),
MemorySize.MemoryUnit.MEGA_BYTES).getMebiBytes();
--- End diff --
Imagine a case when previously we had in configuration:
jobmanager.heap.mb: 1024
which meant 1024 MB, in the new code we will pass 1024 as value for
`jobmanager.heap.size`, which was introduced solely to treat numbers without
units as bytes. Therefore it will be parsed as 1024 bytes rather than 1024 MB.
If we switch the default unit to MB, there is no point for having a new
`ConfigOption`.
---
