[GitHub] flink pull request #6297: [FLINK-9777] YARN: JM and TM Memory must be specif...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6297#discussion_r202017985
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
    @@ -386,10 +386,10 @@ private ClusterSpecification 
createClusterSpecification(Configuration configurat
                }
     
                // JobManager Memory
    -           final int jobManagerMemoryMB = 
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
    +           final int jobManagerMemoryMB = 
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY),
 MemorySize.MemoryUnit.MEGA_BYTES).getMebiBytes();
    --- End diff --
    
    Would it hurt to add `.withDeprecatedKeys("jobmanager.heap.mb")`? In case 
someone does not use the scripts to start the cluster.


---