Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202338957
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -500,11 +501,11 @@ protected Configuration
applyCommandLineOptionsToConfiguration(CommandLine comma
}
if (commandLine.hasOption(jmMemory.getOpt())) {
-
effectiveConfiguration.setString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY,
commandLine.getOptionValue(jmMemory.getOpt()));
+
effectiveConfiguration.setString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY,
commandLine.getOptionValue(jmMemory.getOpt()) + "m");
--- End diff --
I think we have to be a bit smarter here. The unit might be already
provided from cli, right?
---
