[ 
https://issues.apache.org/jira/browse/FLINK-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612065#comment-14612065
 ] 

ASF GitHub Bot commented on FLINK-2311:
---------------------------------------

Github user aalexandrov commented on the pull request:

    https://github.com/apache/flink/pull/880#issuecomment-118066010
  
    OK thanks for the remark. 
    
    Although somewhat verbose, this solves my concrete issue. I wonder if the 
list can be exclusive, e.g.
    
    ```xml
    <!-- use Tweet input format -->
    <dependency>
      <groupId>org.apache.flink</groupId>
      <artifactId>flink-tweet-inputformat</artifactId>
      <version>${project.version}</version>
    </dependency>
    ```
    
    However, it still leaves the question what policy to use for flink-* based 
dependencies. 
    
    As an example, if I want to include `flink-streaming-contrib` in a module 
that is build as a "thin" jar, transitive `flink-*` dependencies that will be 
packaged in the `flink-dist` fat jar do not need to be included.
    
    I therefore suggest to at least make this consistent [with the quickstart 
poms](https://github.com/apache/flink/blob/master/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml)
 and [optionally set the scope of already included dependencies to `provided` 
if the `build-jar` profile is 
activated](https://github.com/apache/flink/blob/master/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml#L317).


> Set flink-* dependencies in flink-contrib as "provided"
> -------------------------------------------------------
>
>                 Key: FLINK-2311
>                 URL: https://issues.apache.org/jira/browse/FLINK-2311
>             Project: Flink
>          Issue Type: Improvement
>          Components: flink-contrib
>    Affects Versions: 0.10, 0.9.1
>            Reporter: Alexander Alexandrov
>            Assignee: Alexander Alexandrov
>            Priority: Minor
>              Labels: easyfix, maven, patch
>             Fix For: 0.10, 0.9.1
>
>
> The {{flink-contrib}} folder is assumed to be provided by the user. As such, 
> other {{flink-*}} dependencies referenced within {{flink-contrib}} should be 
> set as _'provided'_ in order to keep the size of the user jars down. I'm 
> currently testing a patch that changes the poms as suggested and will open a 
> PR on GitHub if this everything passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to