[ 
https://issues.apache.org/jira/browse/FLINK-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611897#comment-14611897
 ] 

ASF GitHub Bot commented on FLINK-2311:
---------------------------------------

Github user mjsax commented on the pull request:

    https://github.com/apache/flink/pull/880#issuecomment-118020199
  
    From my understanding, "provided" would mean that a project that uses stuff 
from flink-contrib would not need to include the code from flink-contrib into 
the own program jar because flink-contrib code is provided automatically at 
runtime (ie, is included in flink-dist).
    
    However, Flink follows the opposite approach. "The flink-contrib folder is 
assumed to be provided by the user" means, that flink-contrib stuff is **not** 
included in flink-dist, thus, if flink-contrib stuff is use, the program must 
be contained in a fat-jar that includes flink-contrib classes.


> Set flink-* dependencies in flink-contrib as "provided"
> -------------------------------------------------------
>
>                 Key: FLINK-2311
>                 URL: https://issues.apache.org/jira/browse/FLINK-2311
>             Project: Flink
>          Issue Type: Improvement
>          Components: flink-contrib
>    Affects Versions: 0.10, 0.9.1
>            Reporter: Alexander Alexandrov
>            Assignee: Alexander Alexandrov
>            Priority: Minor
>              Labels: easyfix, maven, patch
>             Fix For: 0.10, 0.9.1
>
>
> The {{flink-contrib}} folder is assumed to be provided by the user. As such, 
> other {{flink-*}} dependencies referenced within {{flink-contrib}} should be 
> set as _'provided'_ in order to keep the size of the user jars down. I'm 
> currently testing a patch that changes the poms as suggested and will open a 
> PR on GitHub if this everything passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to