[
https://issues.apache.org/jira/browse/FLINK-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611719#comment-14611719
]
ASF GitHub Bot commented on FLINK-2311:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/880#issuecomment-117981390
This is an interesting case.
In theory, dependencies should be provided, such that building a fat-jar
does not take them into account. However, when running examples out of
IntelliJ, it does not work if the dependency is in "provided", as the
dependency is not added to the classpath in that case.
In the examples, we hence add them as "compile" scope dependencies. The
storm compatibility layer could follow a rule, though.
@mjsax Can you comment?
> Set flink-* dependencies in flink-contrib as "provided"
> -------------------------------------------------------
>
> Key: FLINK-2311
> URL: https://issues.apache.org/jira/browse/FLINK-2311
> Project: Flink
> Issue Type: Improvement
> Components: flink-contrib
> Affects Versions: 0.10, 0.9.1
> Reporter: Alexander Alexandrov
> Assignee: Alexander Alexandrov
> Priority: Minor
> Labels: easyfix, maven, patch
> Fix For: 0.10, 0.9.1
>
>
> The {{flink-contrib}} folder is assumed to be provided by the user. As such,
> other {{flink-*}} dependencies referenced within {{flink-contrib}} should be
> set as _'provided'_ in order to keep the size of the user jars down. I'm
> currently testing a patch that changes the poms as suggested and will open a
> PR on GitHub if this everything passes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
