Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4894#discussion_r147339907
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonScan.scala
 ---
    @@ -18,55 +18,7 @@
     
     package org.apache.flink.table.plan.nodes
     
    -import org.apache.flink.api.common.functions.Function
    -import org.apache.flink.api.common.typeinfo.TypeInformation
    -import org.apache.flink.table.api.TableConfig
    -import org.apache.flink.table.codegen.{FunctionCodeGenerator, 
GeneratedFunction}
    -import org.apache.flink.types.Row
    -
     /**
       * Common class for batch and stream scans.
       */
    -trait CommonScan[T] {
    -
    -  /**
    -    * We check if the input type is exactly the same as the internal row 
type.
    -    * A conversion is necessary if types differ.
    -    */
    -  private[flink] def needsConversion(
    -      externalTypeInfo: TypeInformation[Any],
    -      internalTypeInfo: TypeInformation[T]): Boolean =
    -    externalTypeInfo != internalTypeInfo
    -
    -  private[flink] def generatedConversionFunction[F <: Function](
    -      config: TableConfig,
    -      functionClass: Class[F],
    -      inputType: TypeInformation[Any],
    -      expectedType: TypeInformation[Row],
    -      conversionOperatorName: String,
    -      fieldNames: Seq[String],
    -      inputFieldMapping: Option[Array[Int]] = None)
    -    : GeneratedFunction[F, Row] = {
    -
    -    val generator = new FunctionCodeGenerator(
    -      config,
    -      false,
    -      inputType,
    -      None,
    -      inputFieldMapping)
    -    val conversion = 
generator.generateConverterResultExpression(expectedType, fieldNames)
    -
    -    val body =
    -      s"""
    -         |${conversion.code}
    -         |return ${conversion.resultTerm};
    -         |""".stripMargin
    -
    -    generator.generateFunction(
    -      conversionOperatorName,
    -      functionClass,
    -      body,
    -      expectedType)
    -  }
    -
    -}
    +trait CommonScan[T]
    --- End diff --
    
    I kept it for consistency. The other operators have a CommonX trait as well.


---

Reply via email to