[GitHub] flink pull request #4894: [FLINK-7548] [table] Improve rowtime support of Ta...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4894#discussion_r146575110
  
    --- Diff: 
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSource.java
 ---
    @@ -89,34 +98,50 @@ public void addColumn(String family, String qualifier, 
Class<?> clazz) {
         * @param charset Name of the charset to use.
         */
        public void setCharset(String charset) {
    -           this.schema.setCharset(charset);
    +           this.hBaseSchema.setCharset(charset);
        }
     
        @Override
        public TypeInformation<Row> getReturnType() {
    -           String[] famNames = schema.getFamilyNames();
    -           TypeInformation<?>[] typeInfos = new 
TypeInformation[famNames.length];
    +           return new RowTypeInfo(getFieldTypes(), getFieldNames());
    +   }
    +
    +   public TableSchema getTableSchema() {
    --- End diff --
    
    Add `@Override` annotation.


---