[GitHub] flink pull request #4894: [FLINK-7548] [table] Improve rowtime support of Ta...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4894#discussion_r146582532
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableSourceUtil.scala
 ---
    @@ -124,9 +124,15 @@ object ExternalTableSourceUtil extends Logging {
               } else {
                 FlinkStatistic.UNKNOWN
               }
    +
               convertedTableSource match {
    -            case s : StreamTableSource[_] => new StreamTableSourceTable(s, 
flinkStatistic)
    -            case _ => new TableSourceTable(convertedTableSource, 
flinkStatistic)
    +            case s: StreamTableSource[_] =>
    --- End diff --
    
    What happens if the table source implements both interfaces?


---