Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r131764752
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala
---
@@ -415,7 +406,13 @@ class RexTimeIndicatorMaterializer(
case _ =>
updatedCall.getOperands.map { o =>
if (isTimeIndicatorType(o.getType)) {
- rexBuilder.makeCall(TimeMaterializationSqlFunction, o)
+ if (isRowtimeIndicatorType(o.getType)) {
--- End diff --
Not sure. The duplicated code is spread over 2 classes and differently
parameterized. I tried to add a companion object to
`RexTimeIndicatorMaterializer` and the method but this did not really improve
the code, IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
