Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r131713099
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1104,6 +1106,19 @@ abstract class CodeGenerator(
}
}
+ private[flink] def generateStreamRecordTimestampAcccess():
GeneratedExpression = {
+ val resultTerm = newName("result")
+ val nullTerm = newName("isNull")
+
+ val accessCode =
+ s"""
+ |long $resultTerm = $contextTerm.timestamp();
--- End diff --
This could lead to a NPE, I would reintroduce the exception from
`generateRecordTimestamp`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
