Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4488#discussion_r131726136
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1136,25 +1142,31 @@ object AggregateUtil {
}
}
- private[flink] def computeWindowStartEndPropertyPos(
- properties: Seq[NamedWindowProperty]): (Option[Int], Option[Int]) = {
+ private[flink] def computeWindowPropertyPos(
+ properties: Seq[NamedWindowProperty]): (Option[Int], Option[Int],
Option[Int]) = {
- val propPos = properties.foldRight((None: Option[Int], None:
Option[Int], 0)) {
+ val propPos = properties.foldRight(
+ (None: Option[Int], None: Option[Int], None: Option[Int], 0)) {
(p, x) => p match {
--- End diff --
Could you name `x` to (a, b, c)? It is hard to read things like `(x._1,
Some(x._4), x._3, x._4 - 1)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
