Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4488#discussion_r131720129
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
 ---
    @@ -148,6 +142,20 @@ class DataStreamGroupWindowAggregate(
             "state size. You may specify a retention time of 0 to not clean up 
the state.")
         }
     
    +    val timestampedInput = if (isRowtimeAttribute(window.timeAttribute)) {
    +      // copy the window rowtime attribute into the StreamRecord timestamp 
field
    +      val timeAttribute = 
window.timeAttribute.asInstanceOf[ResolvedFieldReference].name
    +      val timeIdx = inputSchema.logicalFieldNames.indexOf(timeAttribute)
    +
    +      inputDS
    +        .process(
    +          new 
TimestampSetterProcessFunction(timeIdx,CRowTypeInfo(inputSchema.physicalTypeInfo)))
    --- End diff --
    
    missing space


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to