GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/4488

    [FLINK-7337] [table] Refactor internal handling of time indicator 
attributes.

    ## What is the purpose of the change
    
    Handle time indicators attributes as physical fields in `Row`.
    - support for multiple event-time time attributes (required for proper join 
handling)
    - no distinction of logical and physical schema
    
    ## Brief change log
    
    - Expand phyiscal Row schema for time indicators.
    - Refactor computation of logical schema of tables to import.
    - `StreamRecord` timestamps are moved into `Row` during initial conversion
    - Refactor operators to use time attribute in Row instead of StreamRecord 
timestamp.
    - timestamps are copied into `StreamRecord` when `Table` is converted into 
`DataStream`.
    - Drive-by fix for NPE in `generateInputFieldUnboxing`
    
    ## Verifying this change
    
    - Changes are mostly internal. 
    - No new features or public APIs have been added. 
    - All existing tests pass.
    - Tests have been added to verify that time indicators are copied when 
`Table` is converted into `DataStream`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **yes**
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **na**
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableTimeIndi

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4488.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4488
    
----
commit accf80587b5a7455fb913b5860f973b3a738765a
Author: Fabian Hueske <fhue...@apache.org>
Date:   2017-08-04T00:20:56Z

    [FLINK-7337] [table] Refactor internal handling of time indicator 
attributes.
    
    - Expand phyiscal Row schema for time indicators.
    - Refactor computation of logical schema of tables to import.
    - Refactor operators to use time attribute in Row instead of StreamRecord 
timestamp.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to